Closed quequegg closed 5 years ago
alandgri
commented
6 years ago This is complete right now in Dev, as of commit #109 . Right now there is no way to add a user through the UI, must be done through the DB. Next on my list is the interface to add and maintain users, accessible only to administrators defined within the application.
alandgri
commented
6 years ago The interface to manage users and define administrators is mostly complete and functional in Dev. Because more pages and navigation points were introduced, I also created a navigation bar at the top of the page as a place to hold all of the navigation links. Looks fairly slick in my opinion.
quequegg
commented
6 years ago I love seeing the progress.
I need a little help ... I added an organization so I guess I am an administrator. Can I have an organization who has the right to change their profile but who cannot create another organization?
Thanks for the new code! Loved seeing the logo in a corner.
Bob
On Mon, Jan 8, 2018 at 11:00 AM, alandgri notifications@github.com wrote:
The interface to manage users and define administrators is mostly complete and functional in Dev. Because more pages and navigation points were introduced, I also created a navigation bar at the top of the page as a place to hold all of the navigation links. Looks fairly slick in my opinion.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Discordanian/mmatch/issues/107#issuecomment-356026969, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad32Pn-RZxcDRY4JsXVqvqoUOpoJWng_ks5tIkmqgaJpZM4RDv2r .
alandgri
commented
6 years ago The user, once authenticated, can create multiple organizations. I can see that this would be necessary and if I recall correctly we saw it in the Arizona data. One person was the contact person for multiple organizations. Also true with people that I know that volunteer for multiple nonprofits. If you have a person who is “good” at doing Movement Match why wouldn’t we let them create multiple.
In any case it would be easy to set up some sort of limit to the number that they can create or maybe rate limits.
On Mon, Jan 8, 2018 at 8:37 PM Bob the Modeler notifications@github.com wrote:
I love seeing the progress.
I need a little help ... I added an organization so I guess I am an administrator. Can I have an organization who has the right to change their profile but who cannot create another organization?
Thanks for the new code! Loved seeing the logo in a corner.
Bob
On Mon, Jan 8, 2018 at 11:00 AM, alandgri notifications@github.com wrote:
The interface to manage users and define administrators is mostly complete and functional in Dev. Because more pages and navigation points were introduced, I also created a navigation bar at the top of the page as a place to hold all of the navigation links. Looks fairly slick in my opinion.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub < https://github.com/Discordanian/mmatch/issues/107#issuecomment-356026969>, or mute the thread < https://github.com/notifications/unsubscribe-auth/Ad32Pn-RZxcDRY4JsXVqvqoUOpoJWng_ks5tIkmqgaJpZM4RDv2r
.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Discordanian/mmatch/issues/107#issuecomment-356162063, or mute the thread https://github.com/notifications/unsubscribe-auth/AdeKTmuF3BWULEra9a-7OltYLymO1stOks5tItD-gaJpZM4RDv2r .
quequegg
commented
6 years ago So is the control at the user level then? Only a MM Dba would create the user then the user can create 0-n organizations?
I think this would be fine. Do you want to implement some complexity to the passwords? Maybe an email alert when an org is accessed?
Thanks for the explanation, Bob
On Mon, Jan 8, 2018 at 9:30 PM alandgri notifications@github.com wrote:
The user, once authenticated, can create multiple organizations. I can see that this would be necessary and if I recall correctly we saw it in the Arizona data. One person was the contact person for multiple organizations. Also true with people that I know that volunteer for multiple nonprofits. If you have a person who is “good” at doing Movement Match why wouldn’t we let them create multiple.
In any case it would be easy to set up some sort of limit to the number that they can create or maybe rate limits.
On Mon, Jan 8, 2018 at 8:37 PM Bob the Modeler notifications@github.com wrote:
I love seeing the progress.
I need a little help ... I added an organization so I guess I am an administrator. Can I have an organization who has the right to change their profile but who cannot create another organization?
Thanks for the new code! Loved seeing the logo in a corner.
Bob
On Mon, Jan 8, 2018 at 11:00 AM, alandgri notifications@github.com wrote:
The interface to manage users and define administrators is mostly complete and functional in Dev. Because more pages and navigation points were introduced, I also created a navigation bar at the top of the page as a place to hold all of the navigation links. Looks fairly slick in my opinion.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub < https://github.com/Discordanian/mmatch/issues/107#issuecomment-356026969 , or mute the thread <
.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub < https://github.com/Discordanian/mmatch/issues/107#issuecomment-356162063>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AdeKTmuF3BWULEra9a-7OltYLymO1stOks5tItD-gaJpZM4RDv2r
.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Discordanian/mmatch/issues/107#issuecomment-356169768, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad32PtER6dEftnEpKUA9b9SaXvKj8h9rks5tIt1cgaJpZM4RDv2r .
alandgri
commented
6 years ago You got it, a user can create 0-n orgs. I have a few small clean up tasks to make the current model complete, like the ability for an admin to change the user that an org is tied to.
I could implement password complexity rules. Something simple like length of 8 and must contain 2 or 3 classes of characters (between letters, capitals, numbers, and specials).
On Tue, Jan 9, 2018 at 9:22 AM Bob the Modeler notifications@github.com wrote:
So is the control at the user level then? Only a MM Dba would create the user then the user can create 0-n organizations?
I think this would be fine. Do you want to implement some complexity to the passwords? Maybe an email alert when an org is accessed?
Thanks for the explanation, Bob
On Mon, Jan 8, 2018 at 9:30 PM alandgri notifications@github.com wrote:
The user, once authenticated, can create multiple organizations. I can see that this would be necessary and if I recall correctly we saw it in the Arizona data. One person was the contact person for multiple organizations. Also true with people that I know that volunteer for multiple nonprofits. If you have a person who is “good” at doing Movement Match why wouldn’t we let them create multiple.
In any case it would be easy to set up some sort of limit to the number that they can create or maybe rate limits.
On Mon, Jan 8, 2018 at 8:37 PM Bob the Modeler <notifications@github.com
wrote:
I love seeing the progress.
I need a little help ... I added an organization so I guess I am an administrator. Can I have an organization who has the right to change their profile but who cannot create another organization?
Thanks for the new code! Loved seeing the logo in a corner.
Bob
On Mon, Jan 8, 2018 at 11:00 AM, alandgri notifications@github.com wrote:
The interface to manage users and define administrators is mostly complete and functional in Dev. Because more pages and navigation points were introduced, I also created a navigation bar at the top of the page as a place to hold all of the navigation links. Looks fairly slick in my opinion.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <
https://github.com/Discordanian/mmatch/issues/107#issuecomment-356026969 ,
or mute the thread <
.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub < https://github.com/Discordanian/mmatch/issues/107#issuecomment-356162063 , or mute the thread <
.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub < https://github.com/Discordanian/mmatch/issues/107#issuecomment-356169768>, or mute the thread < https://github.com/notifications/unsubscribe-auth/Ad32PtER6dEftnEpKUA9b9SaXvKj8h9rks5tIt1cgaJpZM4RDv2r
.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Discordanian/mmatch/issues/107#issuecomment-356315050, or mute the thread https://github.com/notifications/unsubscribe-auth/AdeKTqIUqNWUxB61ehPKaNsodMio68Gyks5tI4QZgaJpZM4RDv2r .
alandgri
commented
6 years ago Last function for this issue is the ability for an administrator to create an organization tied to another user and/or tie an existing organization to another user. (Right now, everyone can only edit/add orgs tied to their own user.)
alandgri
commented
6 years ago We talked about this in person, and decided that the way to reflect this UX wise is to show it in the user page, show the orgs tied to the user, and allow the user to "adopt" an existing org. Note that only admins can do this functionality, which makes sense, because only admins can edit random user records anyway.
quequegg
commented
6 years ago I agree that this is the most natural way to do this.
On Sat, Feb 24, 2018 at 11:49 AM, alandgri notifications@github.com wrote:
We talked about this in person, and decided that the way to reflect this UX wise is to show it in the user page, show the orgs tied to the user, and allow the user to "adopt" an existing org. Note that only admins can do this functionality, which makes sense, because only admins can edit random user records anyway.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Discordanian/mmatch/issues/107#issuecomment-368246128, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad32PtuLYKLlsFQgwLGuxVGy1_5npK8Mks5tYEvCgaJpZM4RDv2r .
alandgri
commented
6 years ago What is in dev right now is a really rough draft of this functionality. I wanted to get some feedback before pushing through.
If you go into a user record as an administrator, you have a new section of the page at the bottom which allows you to select one or more orgs to link to the user you are editing.
For it to be finished, I want to create a warning message and confirmation dialog box that basically says "are you sure, because if you do this, another user may no longer be able to edit that org?" kind of thing.
quequegg
commented
6 years ago Alan! Thank you so much for your work on this.
I am volunteering with Sierra Club this morning - partly because I intend to twist their arms about signing up ... they are the only organization that has told me no.
Bob
On Fri, Mar 2, 2018 at 11:08 PM, alandgri notifications@github.com wrote:
What is in dev right now is a really rough draft of this functionality. I wanted to get some feedback before pushing through.
If you go into a user record as an administrator, you have a new section of the page at the bottom which allows you to select one or more orgs to link to the user you are editing.
For it to be finished, I want to create a warning message and confirmation dialog box that basically says "are you sure, because if you do this, another user may no longer be able to edit that org?" kind of thing.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Discordanian/mmatch/issues/107#issuecomment-370119391, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad32Ppbdd1FLLnmEehGClJ_4FXYsilyrks5taiUygaJpZM4RDv2r .
-- Bob Schmidt Find me on Fb at "Robert Schmidt" https://www.facebook. com/robertphilipschmidt https://go.shmtrk.com/url.php?utm=476291519137409&r=https%3A%2F%2Fwww.facebook.com%2Frobertphilipschmidt Linked in: linkedin.com/in/bob-schmidt-data-model https://link.shmtrk.com/url.php?utm=793991519137409&r=http%3A%2F%2Flinkedin.com%2Fin%2Fbob-schmidt-data-model or old school - 314-397-6406 https://go.shmtrk.com/url.php?utm=938691519137409&r=tel%3A%28314%29%2520397-6406
quequegg
commented
6 years ago I do not see why you say it is a rough draft ... looks and works good insofar as some casual testing would show. I successfully moved ARC from me to you.
I could imagine the kinds of things that would be said in a typical design meeting about the way this is set up ... but I think what you have is functional and has the quality of simplicity that is often lacking in large scale projects. I like it.
BTW, there is another business case for this feature. Today I got an entirely new contact at the Sierra Club so I moved it from one app user to a new one using SQL; your feature would have worked for that.
Bob
On Fri, Mar 2, 2018 at 11:08 PM, alandgri notifications@github.com wrote:
What is in dev right now is a really rough draft of this functionality. I wanted to get some feedback before pushing through.
If you go into a user record as an administrator, you have a new section of the page at the bottom which allows you to select one or more orgs to link to the user you are editing.
For it to be finished, I want to create a warning message and confirmation dialog box that basically says "are you sure, because if you do this, another user may no longer be able to edit that org?" kind of thing.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Discordanian/mmatch/issues/107#issuecomment-370119391, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad32Ppbdd1FLLnmEehGClJ_4FXYsilyrks5taiUygaJpZM4RDv2r .
-- Bob Schmidt Find me on Fb at "Robert Schmidt" https://www.facebook. com/robertphilipschmidt https://go.shmtrk.com/url.php?utm=476291519137409&r=https%3A%2F%2Fwww.facebook.com%2Frobertphilipschmidt Linked in: linkedin.com/in/bob-schmidt-data-model https://link.shmtrk.com/url.php?utm=793991519137409&r=http%3A%2F%2Flinkedin.com%2Fin%2Fbob-schmidt-data-model or old school - 314-397-6406 https://go.shmtrk.com/url.php?utm=938691519137409&r=tel%3A%28314%29%2520397-6406
I suggest that in the short term, we disable the add logic from the existing screens. To add an organization we would run DML ... a dba would do it for the users. I think this is a point at which we could be brought into a bad place if someone were to be malicious.
In the long run, we need a different kind of user who has the rights to add an organization using the existing logic.