search

DiscoverMeteor / book

17 stars 0 forks source link

Issue with Route '/' in Voting Chapter Under Ranking the Front Page Posts Section #375

Closed ghost closed 10 years ago

ghost commented 10 years ago

Under "Ranking the Front Page Posts" section on Voting chapter, looking at the code block for "lib/router.js", I think the path needs to be '/:postsLimit?' instead of '/', the load more doesn't work on the homepage without '/:postsLimit?'. In this case, then I've put the home router below newPosts and bestPosts, because it seemed like home router interfered with those routers if put on top.

Also, please note that the "New" tab is highlighted when the homepage is opened, this is odd.

SachaG commented 10 years ago

I'm not sure if I follow entirely, but the "load more" link should point to /new/10, not /10. Which is why it should work even if we don't have a /:postsLimit? path. Does that answer your question?

And the homepage is the New tab. Although in my case the tab isn't highlighted as far as I can tell.

ghost commented 10 years ago

Yup that clarifies the book's intentions. Thanks!