search

DiscoveryGC / FLHook

FLHook for Discovery Freelancer
Other
28 stars 33 forks source link

base: fix for docking bug, a.k.a. "Your reputation stinks" (fixed 12.10.20) #128

Closed dd84ai closed 3 years ago

dd84ai commented 4 years ago

Fix to pob docking problem https://github.com/DiscoveryGC/FLHook/issues/47 It prevents playercntl plugin interference, which incorrect worked caused "your reputation stinks" and etc during pob dock randomly

dd84ai commented 4 years ago

wait a second, it has not solved problems yet

dd84ai commented 4 years ago

now it is working regardless of which plugin is loaded first. done,

dd84ai commented 4 years ago

Resolved

dd84ai commented 4 years ago

Discovered it can be coded possibly easier than I did

dd84ai commented 4 years ago

Remade to remove not optimized trash ;b

dd84ai commented 4 years ago

What about the -0.55 check on POBs? Players shouldn't be able to dock if their reputation with the base's affiliation is too close to hostile right?

This restriction is supposed to be applied only during defensemode == 2, when base allows docking rights from player reputation Perhaps sometime later, someone could fix it. It is not a really important feature anyway, too overspecialized. There would be needed changes in IsDockingAllowed function which aren't directly related to the current PR