search

DiscoveryGC / FLHook

FLHook for Discovery Freelancer
Other
28 stars 33 forks source link

baseplugin: Adding -0.55 rep restriction to dock #142

Closed dd84ai closed 1 year ago

dd84ai commented 3 years ago

During defensemodes 2 People can dock based on their reputation

At the moment it is not restricting from docking people with -0.55 reputation While actually supposed to block and say things like "Your reputation stinks" and other things that can be found in playercntl

It needs to be fixed, and I am recommending regulating it purely through base plugin in the next function: static bool IsDockingAllowed(PlayerBase *base, uint client)

reputation can be acquired in this func float PlayerBase::GetAttitudeTowardsClient(uint client)

dd84ai commented 3 years ago

After consideration, I decided to be not touching it while PR https://github.com/DiscoveryGC/FLHook/pull/130 is not merged at least. Because it already changes the docking permissions function and I don't want to have trouble with merging more than needed.

Aingar commented 1 year ago

Fixed at some point leading up to 5.0 release