DiseaseOntology / HumanDiseaseOntology

Repository for the Human Disease Ontology.
Creative Commons Zero v1.0 Universal
347 stars 109 forks source link

Polycystic liver disease subtypes #1351

Closed csbjohnson closed 2 months ago

csbjohnson commented 4 months ago

Phenotypic Series - PS174050

allenbaron commented 4 months ago

Since these are subtypes of polycystic liver disease I think it makes sense to make them children of the existing 'polycystic liver disease' (DOID:0050770).

Also, the MIM xref on DOID:0050770 (and possibly others) is to POLYCYSTIC LIVER DISEASE 1. When adding genetic subtypes to an existing disease that lacks a genetic cause in the definition, its best practice to keep that definition as is, since annotations may be to varying genetic causes, and to create a new disease subtype for each genetic cause, moving xrefs to these subtypes as appropriate. In this case, that means the new 'polycystic liver disease 1' subtype also needs to be created and all the xrefs that specify the genetic cause equivalent to that should be moved to this subtype. Then, xrefs to grouping terms in OMIM (i.e. the phenotypic series) and other clinical vocabularies, where it exists, should be added to the original 'polycystic liver disease' (DOID:0050770).

allenbaron commented 4 months ago

Also note that "with or without" phrases should be excluded in DO disease names (they can be added as synonyms). The only exception would be if they are absolutely necessary to distinguish one disease from another, and I am not aware of any instances where this applies.

My apologies that this info wasn't included in my curation notes. I've added it now.