search

Disfactory / frontend

Frontend of disfactory.tw. Built with Vue.js. For backend please checkout https://github.com/Disfactory/Disfactory
https://disfactory.tw
MIT License
19 stars 16 forks source link

add: popover menu for setting button sheet, close #43 #162

Closed howard-tzw closed 2 years ago

howard-tzw commented 2 years ago

resolve issue #43

netlify[bot] commented 2 years ago

Deploy request for dreamy-dijkstra-527e49 pending review.

Visit the deploys page to approve it

Name Link
Latest commit ceb6f4810cc7a2088169befd4fc6bfee02c9d353
Yukaii commented 2 years ago

Hi @howard-tzw, thank you for the contribution!

The new menu looks great! However, I still want to keep the old bottom sheet on mobile screen size. Could the new menu only show on the desktop screen? You can use Vuetify breakpoint API:

https://github.com/Disfactory/frontend/blob/4ea3e9f66b0e682909a1687db5b1ce97457fd3a5/src/components/FactoryDetailPage.vue#L67

Desktop Design: https://www.figma.com/file/nTYqE10obqYSy2x9zY6Oer/Disfactory_UI_design?node-id=494%3A7845 Mobile Design: https://www.figma.com/file/nTYqE10obqYSy2x9zY6Oer/Disfactory_UI_design?node-id=244%3A1177

howard-tzw commented 2 years ago

Hi @Yukaii, I updated the commit for the old button on mobile screen size, please help me review the code, thanks!

Yukaii commented 2 years ago

It works pretty well! Thank you for the contribution @howard-tzw 🎉