search

Display-Lab / psdo

Performance Summary Display Ontology
https://display-lab.github.io/psdo/
Other
3 stars 3 forks source link

Remove Quotations in Term Definitions? #142

Closed CooperStansbury closed 6 years ago

CooperStansbury commented 6 years ago

Currently there are several definitions that have quotation marks in them. I believe this signals that the definitions are direct citations from literature, but I'm not entirely sure.

How do we feel about removing the quotation marks? Likely these definitions will need to change to reflect true Aristotelian form in the future, so my thought is we should remove them and rely on the annotation properties to structure this 'metadata.'

Example: comparator: "A performer to which a performance report is not deliver, and to which a recipient can be compared" http://purl.obolibrary.org/obo/fio#FIO_0000037

zachll commented 6 years ago

Yes, better to remove quotation marks and cite sources in annotations

CooperStansbury commented 6 years ago

@grosscol @zachll it turns out the quotation marks are not part of the .owl file. They are not present in the raw file nor are they present in protege.

I believe that they are a product of the ROBOT query used to extract them from the ontology, but I cannot figure out where/when they're generated. They appear in the dictionary and in the dictionary.csv file in the .gitignore but nowhere else.

I do not think it's worth it to chase this down, but maybe @grosscol will know what's going on quickly. Close when ready.

grosscol commented 6 years ago

Related to and can be rolled into #141