search

Display-Lab / psdo

Performance Summary Display Ontology
https://display-lab.github.io/psdo/
Other
3 stars 3 forks source link

Development wip - Fix IAO import #152

Closed CooperStansbury closed 6 years ago

CooperStansbury commented 6 years ago

@grosscol ontology PURLS are case-sensitive, I just learned. I fixed IAO in the tooling. Will squash if important to you.

grosscol commented 6 years ago

@CooperStansbury These are sufficiently discrete. Looks fine to merge. Is it still a WIP?

CooperStansbury commented 6 years ago

Thinking about leaving this branch as a persistent wip branch and making pull requests when it makes sense, unless there's a reason not to do this.

CooperStansbury commented 6 years ago

@grosscol Alright if I merge?

grosscol commented 6 years ago

I would rather not have persistent branches that we commit directly to. It's easier to track persistent branches if the only changes to them are merges from short lived feature branches. It also limits the possibility of the history getting rewritten on a branch multiple people are working from.

WIP generally means "don't merge this because I'm still working on it."

CooperStansbury commented 6 years ago

Ok. I will stop naming these branches WIP and I will not keep persistent branches.

Merge when ready and I will clean up the branches.

On Wed, May 30, 2018 at 5:15 PM, Colin notifications@github.com wrote:

I would rather not have persistent branches that we commit directly to. It's easier to track persistent branches if the only changes to them are merges from short lived feature branches. It also limits the possibility of the history getting rewritten on a branch multiple people are working from.

WIP generally means "don't merge this because I'm still working on it."

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Display-Lab/psdo/pull/152#issuecomment-393321900, or mute the thread https://github.com/notifications/unsubscribe-auth/AiJ2HbyArxoHLn8NdPNWuHItZQkwg8klks5t3wvygaJpZM4UT3xb .

-- Cooper M. Stansbury University of Michigan - Dearborn College of Engineering and Computer Science M.S. Data Science Candidate (734) 274-1053

grosscol commented 6 years ago

Usually the WIP gets put into and removed from the title of the pull request. So the name of the feature branch can be the issue and number or whatever feature it is that's being implemented by it.

CooperStansbury commented 6 years ago

That makes sense. Thanks,

On Wed, May 30, 2018 at 5:21 PM, Colin notifications@github.com wrote:

Usually the WIP gets put into and removed from the title of the pull request. So the name of the feature branch can be the issue and number or whatever feature it is that's being implemented by it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Display-Lab/psdo/pull/152#issuecomment-393323532, or mute the thread https://github.com/notifications/unsubscribe-auth/AiJ2HR2ClkAC0DS-HMAaeguxQGX-YukUks5t3w1MgaJpZM4UT3xb .

-- Cooper M. Stansbury University of Michigan - Dearborn College of Engineering and Computer Science M.S. Data Science Candidate (734) 274-1053