search

Display-Lab / psdo

Performance Summary Display Ontology
https://display-lab.github.io/psdo/
Other
3 stars 3 forks source link

Term refinement #156

Closed CooperStansbury closed 6 years ago

CooperStansbury commented 6 years ago

Significant changes to the ontology and repo including:

  1. renaming the ontology to 'psdo'
  2. archiving legacy version of the owl
  3. rebuilding import structure based on IAO-Slim.owl
  4. rebuilding psdo.owl from ground-up
  5. refactoring all major classes, labels, and definitions
  6. changing all IRIs
  7. updating semantic versioning to 1.0.0
  8. adding numerous annotation properties to attribute definitions and explain usage
CooperStansbury commented 6 years ago

@grosscol reviewed comments and made changes. Let me know if you want to discuss imports further.

grosscol commented 6 years ago

Squash commits? or do you want this merged as is?

CooperStansbury commented 6 years ago

I can squash and merge, if squashing is important to you.

grosscol commented 6 years ago

My preference is for squashing. Seeing commits such as "updating dictionary" and "term refinement" aren't particularly useful to me after the larger unit of work is set and ready to be merged. Also, if there are incremental steps that don't stand on their own very well I like those squashed into a larger unit of work.

CooperStansbury commented 6 years ago

Will do. I'll merge when finished.

On Fri, Jun 29, 2018 at 3:27 PM Colin notifications@github.com wrote:

My preference is for squashing. Seeing commits such as "updating dictionary" and "term refinement" aren't particularly useful to me after the larger unit of work is set and ready to be merged. Also, if there are incremental steps that don't stand on their own very well I like those squashed into a larger unit of work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Display-Lab/psdo/pull/156#issuecomment-401451485, or mute the thread https://github.com/notifications/unsubscribe-auth/AiJ2HTtger3fkEg_TPrg7sM_-tsJ7kJYks5uBn-3gaJpZM4U9DD1 .

-- Cooper M. Stansbury University of Michigan - Dearborn College of Engineering and Computer Science M.S. Data Science Candidate (734) 274-1053