DisplayLink / evdi

Extensible Virtual Display Interface
MIT License
702 stars 183 forks source link

Regresion - Kernel 5.17.5-200.fc35.x86_64 - mode reject. #357

Open chiddekel opened 2 years ago

chiddekel commented 2 years ago

On kernel 5.17.5-200.fc35.x86_64 mode rejection: (...) [W] evdi_mode_valid:75 Mode 1900x1200@60 rejected (...) Why default mode is 75 and not the range of for example starting from 60?

Olyol95 commented 2 years ago

I'm seeing the same mode rejection issue on 5.17.4-200.fc35.x86_64 when compiled from 39da217.

Why default mode is 75

The 75 quoted in the log line is the line number of the source file where evdi_mode_valid failed.

Olyol95 commented 2 years ago

evdi->pixel_per_second_limit is being set to 3686400 on my machine, despite the connected device being capable of a much larger value. I suspect there's an issue somewhere with the assignment of the value, though I don't know enough about the project to contribute a concrete solution.

For now I have bodged it on my device by inserting the following on line 70 of module/evdi_connector.c.

return MODE_OK;
mikefarmer01 commented 2 years ago

Same issue on kernel 5.18.0-arch1-1

castorls commented 2 years ago

I've the same issue with 5.18.5-200.fc36.x86_64 , evdi version 1.11.0

On first analyze, the internal mode_limit is computed with the refresh frequency and the the provided pixel_per_second_limit parameter in the mode is computed without the frequency.

a simple patch (which may not be the correct fix, I've not really searched for the root cause of the issue) is a vlid workaround on my env :

`diff --git i/module/evdi_connector.c w/module/evdi_connector.c index fae5ca2..3632e7b 100644 --- i/module/evdi_connector.c +++ w/module/evdi_connector.c @@ -66,7 +66,7 @@ static enum drm_mode_status evdi_mode_valid(struct drm_connector connector, struct drm_display_mode mode) { struct evdi_device *evdi = connector->dev->dev_private;

mikefarmer01 commented 2 years ago

Meanwhile, i switched to a Thunderbolt 3 dock.
Don't know what your situation is, but you should consider moving away from DisplayLink as well.

pjboro commented 2 years ago

Recompilation with newer evdi seems to fix the issue. There is an unofficial rpm here: https://github.com/displaylink-rpm/displaylink-rpm/issues/218#issuecomment-1160123098

chiddekel commented 2 years ago

Confirm - evdi 1.12.0 work on Fedora 35 with kernel 5.18.11-100.fc35.x86_64.

zachspar commented 2 years ago

Meanwhile, i switched to a Thunderbolt 3 dock. Don't know what your situation is, but you should consider moving away from DisplayLink as well.

@mikefarmer01, I wish it were that simple for everyone. Not everybody has the luxury of Thunderbolt. In fact, many AMD CPUs don't support it.