DisplayLink / evdi

Extensible Virtual Display Interface
MIT License
708 stars 184 forks source link

Add support for kernel 6.2 #401

Closed listout closed 1 year ago

listout commented 1 year ago

Original patch was suggested by Crashdummyy.

Since commit 9877d8f6bc374912b08dfe862cddbb78b395a5ef in linux kernel feild fbdev has been renamed to info in struct drm_fb_helper.

Fixes: https://github.com/DisplayLink/evdi/issues/394 Fixes: https://github.com/DisplayLink/evdi/issues/384 Fixes: https://github.com/DisplayLink/evdi/issues/402 Signed-off-by: listout listout@protonmail.com

Before submitting the PR please make sure you have run ci scripts:

If you have more than one change consider creating separate PRs for them; it will make the review process much easier. Also provide some description (links to source code or mailing list are welcome - this might help to understand the change).

Thanks for the contribution!

cmmrandau commented 1 year ago

Switched to Fedora 38 and the dock works out of the box without even having to install the displaylink driver. <:D

Thanks for the tip!

bryn1u commented 1 year ago

Checked and tested:

Working like a charm on Ubuntu 23.03 - Beta. "Linux Proton 6.2.0-19-generic #19-Ubuntu" Working like a charm on Pop OS 22.04 with kernel 6.2.0

igudich commented 1 year ago

Switched to Fedora 38 and the dock works out of the box without even having to install the displaylink driver. <:D

Thanks for the tip!

So, am I right, Fedora 38 supports displaylink out of the box?

Crashdummyy commented 1 year ago

Switched to Fedora 38 and the dock works out of the box without even having to install the displaylink driver. <:D Thanks for the tip!

So, am I right, Fedora 38 supports displaylink out of the box?

I highly doubt that. That would imply that we dont need evdi as dkms module as well. Im on 6.3.0-0.rc6.20230416gt3e7bb4f2.254.vanilla.fc37.x86_64 and once I unload evdi my displays stop working ( as expected )

TonyGiorgio commented 1 year ago

I've had no issues after switching to Dell WD19TB.

cmmrandau commented 1 year ago

Switched to Fedora 38 and the dock works out of the box without even having to install the displaylink driver. <:D Thanks for the tip!

So, am I right, Fedora 38 supports displaylink out of the box?

Yes, it works without installing the displaylink driver. It's on a Lenovo laptop connected to Lenovo dock. Can't see evdi in dkms, so I'm not sure what driver it's using or how it works. Let me know if you want me to post any command.

Crashdummyy commented 1 year ago

I just installed Fedora 38 beta and my dock wont work without those drivers. Maybe it depends on the dock but I guess yours probably might've worked without displaylink anyway

cmmrandau commented 1 year ago

I just installed Fedora 38 beta and my dock wont work without those drivers. Maybe it depends on the dock but I guess yours probably might've worked without displaylink anyway

The same dock did not work ootb in Ubuntu 23.04 and not with displaylink either, which is why I came here in the first place.

sebaschi commented 1 year ago

Upgraded from Fedora 37 (which recently had stopped working with DL) to Fedora 38. For me it does not work out of the box. I applied (at least I think I did) the patch and then other functions where undefined. I'm left with Apr 20 01:45:54 fedora systemd[1]:displaylink-driver.service: Consumed 8.296s CPU time.

Apr 20 01:45:54 fedora systemd[1]: Failed to start displaylink-driver.service - DisplayLink Driver Service.
Apr 20 01:45:54 fedora systemd[1]: displaylink-driver.service: Failed with result 'exit-code'.
Apr 20 01:45:54 fedora systemd[1]: displaylink-driver.service: Control process exited, code=exited, status=10/n/a
Apr 20 01:45:54 fedora sh[7388]: Consult /var/lib/dkms/evdi/1.12.0/build/make.log for more information.
Apr 20 01:45:54 fedora sh[7388]: Error! Bad return status for module build on kernel: 6.2.11-300.fc38.x86_64 (x86_64)
Apr 20 01:45:54 fedora sh[6858]: make -j20 KERNELRELEASE=6.2.11-300.fc38.x86_64 all INCLUDEDIR=/lib/modules/6.2.11-300.fc38.x86_64/build/include KVERSION=6.2.11-300.fc38.x>
Apr 20 01:45:53 fedora sh[6858]: Cleaning build area...
Apr 20 01:45:53 fedora sh[6858]: Building module:
Apr 20 01:45:52 fedora sh[6858]: Public certificate (MOK): /var/lib/dkms/mok.pub
Apr 20 01:45:52 fedora sh[6858]: Signing key: /var/lib/dkms/mok.key
Apr 20 01:45:52 fedora sh[6858]: Sign command: /lib/modules/6.2.11-300.fc38.x86_64/build/scripts/sign-file
Crashdummyy commented 1 year ago

Upgraded from Fedora 37 (which recently had stopped working with DL) to Fedora 38. For me it does not work out of the box. I applied (at least I think I did) the patch and then other functions where undefined. I'm left with Apr 20 01:45:54 fedora systemd[1]:displaylink-driver.service: Consumed 8.296s CPU time.

Apr 20 01:45:54 fedora systemd[1]: Failed to start displaylink-driver.service - DisplayLink Driver Service.
Apr 20 01:45:54 fedora systemd[1]: displaylink-driver.service: Failed with result 'exit-code'.
Apr 20 01:45:54 fedora systemd[1]: displaylink-driver.service: Control process exited, code=exited, status=10/n/a
Apr 20 01:45:54 fedora sh[7388]: Consult /var/lib/dkms/evdi/1.12.0/build/make.log for more information.
Apr 20 01:45:54 fedora sh[7388]: Error! Bad return status for module build on kernel: 6.2.11-300.fc38.x86_64 (x86_64)
Apr 20 01:45:54 fedora sh[6858]: make -j20 KERNELRELEASE=6.2.11-300.fc38.x86_64 all INCLUDEDIR=/lib/modules/6.2.11-300.fc38.x86_64/build/include KVERSION=6.2.11-300.fc38.x>
Apr 20 01:45:53 fedora sh[6858]: Cleaning build area...
Apr 20 01:45:53 fedora sh[6858]: Building module:
Apr 20 01:45:52 fedora sh[6858]: Public certificate (MOK): /var/lib/dkms/mok.pub
Apr 20 01:45:52 fedora sh[6858]: Signing key: /var/lib/dkms/mok.key
Apr 20 01:45:52 fedora sh[6858]: Sign command: /lib/modules/6.2.11-300.fc38.x86_64/build/scripts/sign-file

Well it used to run so you can actually just replace the files.

-MODVER=1.13.1 +MODVER=1.12.0

ifeq ($(KVER),) KVER := $(shell uname -r) diff --git a/module/dkms.conf b/module/dkms.conf index 5343de3..3fa8276 100644 --- a/module/dkms.conf +++ b/module/dkms.conf @@ -7,7 +7,7 @@ #

PACKAGE_NAME="evdi" -PACKAGE_VERSION=1.13.1 +PACKAGE_VERSION=1.12.0 AUTOINSTALL=yes

MAKE[0]="make all INCLUDEDIR=/lib/modules/$kernelver/build/include KVERSION=$kernelver DKMS_BUILD=1"


* Copy everytyhing in `module` to `/usr/src/evdi-1.12.0`
Crashdummyy commented 1 year ago

Btw they published v5.7 on the synaptics page which uses the 1.13.1 now. I made an copr in case anyone using fedora is interested and Ill try to keep it up to date

displaylink-emajewsk commented 1 year ago

Closing this, as the 5.7 standalone driver has made its way to the Synaptics download page