search

DisposaBoy / GoSublime

A Golang plugin collection for SublimeText 3, providing code completion and other IDE-like features.
MIT License
3.42k stars 302 forks source link

Making GoSublime and Vintageous play better together #506

Closed guillermooo closed 5 years ago

guillermooo commented 10 years ago

@DisposaBoy Would you be interested in making GoSublime more robust while using Vintageous at the same time?

Key biding conflicts in ordinary views will be a problem in the future, but for now I'm trying to avoid overriding GoSublime's main key bindings.

The problem now is that Vintageous is active for some GoSublime output panels that should probably be ignored instead. There isn't a tried and true method to avoid this, but I'm experimenting with simply using settings.

Would a patch be welcome?

More info here:

https://github.com/guillermooo/Vintageous/wiki/Disabling

DisposaBoy commented 10 years ago

What kinda changes were you thinking of? IIUC that setting would disable the the vim keys in all .go files at which point I wonder why you wouldn't just uninstall Vintageous (speaking as someone unfamiliar with it)

guillermooo commented 10 years ago

I'm speaking about any output panel (not regular views) where you require user input, such as 9o's console. I haven't tried yet, but it'be a matter of going view.settings().set('__vi_external_disable', True) before it's displayed. That way Vim keys would not be available in it, while remaining active in any other regular .go view.

DisposaBoy commented 10 years ago

In that case, I'm not sure I understand the issue. The only keybindings in the 9o panel is ctrl+dot,ctrl+g the same as .go files. Is the intent to make insert mode be on if it's open or something?

zoli commented 10 years ago

In 9o command line there is conflict with vintageous for example when i hit ESC on the 9o command line it won't close it will switch to visual mode in vintageous

DisposaBoy commented 10 years ago

@ZiDoMs I can imagine that case, but it's the same thing that I'm trying to understand from my last comment. If it breaks that way in 9o, how does it not break in the .go view. i.e. what's different about it. If I press escape in a .go view, it should close the output panel (whether or not it's owned by 9o).

zoli commented 10 years ago

This problem is happening sometimes and sometimes it's just fine i couldn't figure out what is causing this,you are right it should break in .go view to but it doesn't

vastbinderj commented 10 years ago

What I notice as a vintageous user is that at times the 9o panel becomes confused due to vintageous being enabled. What Guillermooo suggests is to disable vintageous only in the 9o panel. It isn't a matter of insert mode being enabled.

This same weirdness happens in SublimeGit as well when using vintageous.

DisposaBoy commented 10 years ago

I'm still have no idea what the issue is. What does confused mean. What does weirdness mean.