search

DispuutHamers / webapp

https://www.zondersikkel.nl/
6 stars 0 forks source link

Sidekiq #579

Open koenjdejong opened 1 year ago

koenjdejong commented 1 year ago

Fixes #503

koenjdejong commented 1 year ago

It worked the whole time, it was just cached...

dexbleeker commented 1 year ago

Ref #503

dexbleeker commented 1 year ago

Why are you resolving comments without adressing them? Or at least explaining why the comments are irrelevant or inapplicable or something like that?

koenjdejong commented 1 year ago

The comments I resolved were irrelevant because of new changes to the code. The only comment which actually questioned something which I resolved was:

Why do you override this? The default (a docker compose generated one) is usually preferred because if you have multiple compose stacks running simultaneously, you can distinguish which stack a container belongs to. There might be a good reason to do so though, so curious why you opt for this.

In this case, the default is indeed better, but for personal projects, I like to rename containers to keep portainer a bit neater. This is nog preferred here, so I removed those forced names.