Regression in recent commit causes crash

DissectMalware / XLMMacroDeobfuscator

Extract and Deobfuscate XLM macros (a.k.a Excel 4.0 Macros)

Apache License 2.0

570 stars 115 forks source link

Closed jhhcs closed 2 years ago

jhhcs commented 2 years ago

In 90a58f4a88676ee75db1581394b9503cd4f65e75, code was added that causes XLMDeobfuscator to crash for some samples, see my comment at https://github.com/DissectMalware/XLMMacroDeobfuscator/commit/90a58f4a88676ee75db1581394b9503cd4f65e75#r79357256. An example for a file that can trigger this regression is the (malicious) sample with the following SHA-256 hash:

f272928566acb4bd59315337208ec3be1563864bcd4a40e39e3400715811aa8d

huettenhain commented 2 years ago

See the above PR for a fairly straightforward fix.

DissectMalware commented 2 years ago

Thank you for spotting the error and fixing it; the PR is merged

huettenhain commented 2 years ago

Sweet, and thank you for an awesome tool!