search

Disservin / chess-library

C++ chess library
https://disservin.github.io/chess-library/
MIT License
73 stars 21 forks source link

Renaming methods and properties. #100

Closed miskibin closed 4 months ago

miskibin commented 4 months ago

There is really popular chess library for python. I believe all methods have much better names there. For example instead of board.makeMove you could use board.push. It is shorter and more intuitive. You are pushing Move object. Then you can board.pop If you want.

Disservin commented 4 months ago

Mh I am not sure, this would be a breaking change for everyone, and makeMove is a pretty common name in chess engines. python-chess indeed uses .push and has other names as well, but tbh i haven't see people use these names in real engines anyway... also the author of the python-chess library seems to have moved away from "push" to "play" for his rust library https://github.com/niklasf/shakmaty anyway