full move counter fixes - Githubissues

Disservin / chess-library

C++ chess library

https://disservin.github.io/chess-library/

MIT License

71 stars 22 forks source link

full move counter fixes #26

Closed robertnurnberg closed 12 months ago

robertnurnberg commented 12 months ago

This PR fixes what I believe are four small mistakes regarding the full move counter:

only attempt to read the full move counter from the fen if a sixth parameter is present
initialize the internal auxiliary counter with 2 in the Board class
correctly initialize the internal auxiliary counter when a fen with black to move is read in
have fullMoveNumber() return the move number, rather than the internal auxiliary counter

In a follow up PR I will propose to change the name (and the workings) of full_moves_. But I wanted this bug fix PR to be as simple as possible.