search

Disservin / chess-library

C++ chess library
https://disservin.github.io/chess-library/
MIT License
71 stars 22 forks source link

allow std::istream as pgn source #31

Closed robertnurnberg closed 11 months ago

robertnurnberg commented 11 months ago

No functional change, as std::ifstream is derived from std::istream.

Disservin commented 11 months ago

can you also change the documentation in pgn-utilities.md ? I might have to think of a way to auto generate the docs mh...

Disservin commented 11 months ago

Btw do you have a clue why my ci didnt run for this?

robertnurnberg commented 11 months ago

Done. I thought we might need the more general istream for the .gz decompression in the wdl repo. We will see if we do actually need it there in the end. But good to have it more general in your lib, right?

Disservin commented 11 months ago

Done. I thought we might need the more general istream for the .gz decompression in the wdl repo. We will see if we do actually need it there in the end. But good to have it more general in your lib, right?

Yeah ;)