search

DistanceDevelopment / readdst

Convert Distance for Windows projects into R code/data
GNU General Public License v3.0
1 stars 2 forks source link

Missing vignette in package #37

Closed erex closed 6 years ago

erex commented 6 years ago

Version 0.0.5 installed 30May has no vignette (that I can see), even though repo has a vignette. Was that deliberate--is the old vignette from 2016 out of date? or just a build oversight?

dill commented 6 years ago

Is this as build with R CMD BUILD or some other mechanism?

On 01/06/2018 11:29, erex wrote:

Version 0.0.5 installed 30May has no vignette (that I can see), even though repo has a vignette. Was that deliberate--is the old vignette from 2016 out of date? or just a build oversight?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DistanceDevelopment/readdst/issues/37, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHoSeblDxNO8vyQZtzSV4Pu9RkYjkiks5t4Rd-gaJpZM4UWd1_.

erex commented 6 years ago

Sorry, I don't know the answer to that. I don't know what devtools:::install_github() does.

erex commented 6 years ago

I believe install_github() used R CMD INSTALL rather than R CMD BUILD:

In R CMD INSTALL
"C:/PROGRA~1/R/R-35~1.0/bin/i386/R" --no-site-file --no-environ --no-save  \
  --no-restore --quiet CMD INSTALL  \
  "C:/Users/eric/AppData/Local/Temp/RtmpEj4xCu/devtools24747145170f/DistanceDevelopment-readdst-d060267"  \
  --library="C:/Users/eric/Documents/R/win-library/3.5" --install-tests

What is not produced is an entry in the table of contents for package help, making it difficult for users to find said vignette. Here is the table of contents for DSsim:

image

dill commented 6 years ago

84af359 should fix this (at least using R CMD BUILD then R CMD INSTALL seemed to do the right thing. Eager to know if this works for you using install_github().

screen shot 2018-06-05 at 11 18 04

erex commented 6 years ago

No luck with install_github() either in RStudio image

on with just R image

dill commented 6 years ago

install_github(build_vignettes=TRUE) might solve this?

On 05/06/2018 12:45, erex wrote:

No luck with |install_github()| either in RStudio image https://user-images.githubusercontent.com/330744/40974018-293e2346-68be-11e8-816f-c8e4bba0f98c.png

on with just R image https://user-images.githubusercontent.com/330744/40974058-44c6a21e-68be-11e8-9ca1-882bffc7e1ef.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DistanceDevelopment/readdst/issues/37#issuecomment-394679196, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHoXLWrnh4qdKfQmjeYESQcxjyndHyks5t5m9PgaJpZM4UWd1_.

erex commented 6 years ago

Thanks for reading the documentation for me.
image