search

Distense / distense

Distense contracts and ui
https://disten.se
32 stars 21 forks source link

Contract Architecture (number of contracts and files) #6

Closed DIDHAV closed 7 years ago

DIDHAV commented 7 years ago

There are recommendations to make contracts small, and some bigger and in one place/file. What are the pros and cons of each approach and what approach should Distense take with our contracts?

This issue is about the topics found here. We will definitely need to be able to upgrade at least the token contract (as in reissue the same number of a technically new token with a new contract).

DIDHAV commented 7 years ago

If stuff isn't in one place it will be hard to read how different code will interact with one another.

Sulejman commented 7 years ago

There is lot of decisions to be made here and it cannot be fast process. However, we have one constant in everything and that is once you deploy contracts, they cannot be updated anymore ... only replaced. Maybe good solution would be to have token contracts (for DID and HAV), as they present the core of Distense written once, properly, keeping it simple (with basic options). And for the contract/s which would be responsible for ruling on how much would people get paid for what, voting, decision making, distribution etc, good idea would be to implement Relay contract (to keep same address) like proposed here: https://ethereum.stackexchange.com/questions/2404/upgradeable-smart-contracts Behind relay contract which would act as proxy we may implement and change different rules based on community discussions and needs.