search

DistriNet / tranco-python-package

Python package to access the Tranco list
MIT License
21 stars 9 forks source link

Incorrect loading of not full list #10

Closed maxzhenzhera closed 7 months ago

maxzhenzhera commented 7 months ago

The code here does not strip newlines on not full loading: https://github.com/DistriNet/tranco-python-package/blob/f29ef30316c1c77acde05de7c0ac83929901565d/tranco/tranco.py#L129-L133

maxzhenzhera commented 7 months ago

Therefore, TrancoList contains a list of domains with \n.

VictorLeP commented 7 months ago

Thank you for the report and fix! I merged your PR into version 0.8.1.