search

DistributedCollective / oracle-based-amm

Other
11 stars 5 forks source link

V1 pool oracle #31

Closed amisha120 closed 3 years ago

ororopickpocket commented 3 years ago

approved with one comment. please do not merge before we got a review from @eMarchenko

ororopickpocket commented 3 years ago

would also be nice if

  1. the oracle deployment would be added to the addConverter script
  2. if it would be added to the script for upgrading converters - because that's what we'll need to do. you can use this script as a starting point: https://github.com/DistributedCollective/oracle-based-amm/blob/58e7724124f45839428c2faa3ca329f81ed2313f/solidity/utils/upgrade_converter.js

(the script is in an unmerged PR. we can't merge the whole PR, but you can copy the script)