DistributedProofreaders / dproofreaders

Distributed Proofreaders is a web application intended to ease the process of converting public domain books into e-texts.
https://www.pgdp.net
GNU General Public License v2.0
46 stars 28 forks source link

Collapse Activities in navbar based on avail space (& preference) #1173

Closed cpeel closed 2 months ago

cpeel commented 2 months ago

Introduce the idea of drop-down menu options to group like things together and make better use of the top header space. Much to my chagrin we use the new menu based on a user preference; if the preference is set to "auto" (the default) dynamically use the menu based on the width of the window.

This is available for testing in https://www.pgdp.org/~cpeel/c.branch/refine-navbar/

See also the discussion in the Proposed changes to the navigation bar - 2024 edition forum.

Testing notes: In addition to confirming this works in all our minimum browsers, we should make sure this looks good in all themes -- including having an unread message in the forums which will add an "unread messages" number to the new Inbox icon -- and on various mobile devices.

windymilla commented 2 months ago

Tested in Chrome Version 123.0.6312.105 (Official Build) (64-bit) on Windows: All behaved as expected, including with extremely small/large font sizes, and with all 3 prefs settings.

Love the horizontal drop-down, and the little arrow works for both opening & closing the dropdown.

cpeel commented 2 months ago

Latest commits do the following:

Finally, it includes a separate commit that will allow someone to use the ?numofpages= parameter on TEST to set it to any value, not just lower like it does on PROD.

I'll rebase the fixup commits after we've finished iterating over the changes in the PR & testing.

windymilla commented 2 months ago

Finally, it includes a separate commit that will allow someone to use the ?numofpages= parameter on TEST to set it to any value, not just lower like it does on PROD.

Thanks - just returned a page to the rounds so I'm back down to 99 P1 pages on TEST, and confirmed numofpages param worked correctly for me.

cpeel commented 2 months ago

Some browser testing results, all good.

Our minimum supported versions

Chrome 57 on Windows 10 Firefox 52 on Windows 10 Opera 44 on Windows 10 Safari 11 on High Sierra

Latest versions

Chrome: 123.0 on macOS 12.7 Firefox 124.0.1 on macOS 12.7 Safari 17.4.1 on macOS 12.7 Opera 109 on Windows 10 Edge 123 on Windows 10 Edge 109 on Windows 8 (latest supported on that OS)

Mobile

Firefox on Pixel 4a (vert & horiz) Chrome on Pixel 4a (vert & horiz)

srjfoo commented 2 months ago

iPad running 17.3.1

All three of Safari, Chrome and Firefox look good.

cpeel commented 2 months ago

Last push merely squashed the PR commits into each other. Will merge after CI passes.