DistributedProofreaders / dproofreaders

Distributed Proofreaders is a web application intended to ease the process of converting public domain books into e-texts.
https://www.pgdp.net
GNU General Public License v2.0
46 stars 28 forks source link

Make polytonic greek accents visible in proofreading interface etc. #1225

Closed 70ray closed 3 weeks ago

70ray commented 3 weeks ago

Sandbox at: https://www.pgdp.org/~rp31/c.branch/pi_indent

70ray commented 3 weeks ago

padding works for textareas but not for inputs. I don't know why. text-indent only works on first line in a textarea.

srjfoo commented 3 weeks ago

padding works for textareas but not for inputs. I don't know why. text-indent only works on first line in a textarea.

I think that text-indent works for the textareas as long as you have a return at the end of each line. You have to add each-line along with the indent value. I'm not sure that text-indent was intended to be used the way we used it, though 😁 . I can't swear to it, though, because I was only trying it out in the browser console -- I never got as far as setting up a branch to test that out.

srjfoo commented 3 weeks ago

Bearing in mind that we don't do Greek transcription in the quizzes, and don't have anything that would need the extra indent, should the padding or indent be added to the textarea in the quizzes for consistency's sake?

70ray commented 3 weeks ago

Bearing in mind that we don't do Greek transcription in the quizzes, and don't have anything that would need the extra indent, should the padding or indent be added to the textarea in teh quizzes for consistency's sake?

Yes I'll do that.

70ray commented 3 weeks ago

0.5em padding added to quiz textarea and sandbox updated.

srjfoo commented 3 weeks ago

0.5em padding added to quiz textarea and sandbox updated.

Sorry for not thinking of this earlier, but I'm thinking that Format Preview should be fixed, too. For consistency, if nothing else.

srjfoo commented 3 weeks ago

One more question. We've added padding left for the Greek characters. I am finding that scrollbars of the non-permanent sort overlap text on the right and bottom of the text pane. Would it be reasonable to add .25em to .3em padding there, also, to reduce the effect? (Not specifically asking for it in the PR, just something to consider.)

70ray commented 3 weeks ago

Padding now added in style rather than in-line. Affects PI, quiz and handle_bad_page. Padding also for format preview. Sandbox updated.