search

DistributedProofreaders / dproofreaders

Distributed Proofreaders is a web application intended to ease the process of converting public domain books into e-texts.
https://www.pgdp.net
GNU General Public License v2.0
49 stars 28 forks source link

Target new Tab instead of pop-up windows #405

Open Guy-Sowden opened 4 years ago

Guy-Sowden commented 4 years ago

Target new tab instead of pop-up windows for when opening proofreading menu, pop up windows are now blocked by default in most browsers, and are seen a nuisance for users

function newProofWin(winURL){ nwWin=window.open(winURL,'_blank'); }

I think there may have to be some minor changes to the layout to adjust scaling

cpeel commented 4 years ago

Yes, we need to revisit this. This code was created well before the advent of tabs.

cpeel commented 3 years ago

In Dec 2020 we changed it such that by default, new user profiles have "launch in new window" set to "no". We did not change existing users' profiles, however.

When we have a new proofreading interface I suspect we will remove this option entirely.