Open windymilla opened 10 months ago
Looking at pphtml.py
there are a few changes we'll want to make to use it as a module where we can pass in data.
exit()
s and have it raise exceptions that can be caught.file
command to detect the character set (see charsetCheck()
) which won't work on a buffer and won't work on WIndows.self.sdir
) so we'll want to pass that into the module instead.saveReport()
post-processing. I'll give some thought about if/how we can standardize across toolsSince this is an existing tool we probably want to do some small iterative PRs with these improvements so we can test them individually. Thumbing through it I saw some other improvements we could make which also means we probably need some meager samples to test against to detect regressions along the way.
Given the successful implementation of the functionality of pptxt in GG2, I think it will end up being best to do pphtml in a similar way.
Suggestion: include the functionality of the ppvimage in the new pphtml.
Just putting a few notes here about pphtml to aid us in deciding what to do and how to link pphtml with Guiguts. Just thoughts that I didn't want to lose, rather than definite suggestions of things to do: