DistributedProofreaders / guiguts

Perl/Tk text editor designed for editing and formatting public domain material for inclusion at Project Gutenberg
GNU General Public License v2.0
9 stars 10 forks source link

Tools menu sticky #1273

Closed noystergithub closed 11 months ago

noystergithub commented 12 months ago

Describe the bug After selecting an option off the Tools menu, the menu stays on the screen.

Expected behavior Tools menu should disappear, as the other menus do.

Environment

windymilla commented 12 months ago

Has it always done that? I've never seen it. The only way I know to make a menu stay on screen is to click the "tear-off" line at the top of the menu when you open it.

noystergithub commented 12 months ago

Nigel

No, I think this behaviour began since the change to v1.6.0. It's quite consistent.

What's happening is that the Tools menu on opening behaves as the other menus do when you click on the tear-off line: that is, it automatically opens as a separate movable box.

Neil

On 07/11/2023 19:29 GMT Nigel @.***> wrote:

Has it always done that? I've never seen it. The only way I know to make a menu stay on screen is to click the "tear-off" line at the top of the menu when you open it. — Reply to this email directly, view it on GitHub (https://github.com/DistributedProofreaders/guiguts/issues/1273#issuecomment-1799757573), or unsubscribe (https://github.com/notifications/unsubscribe-auth/A6K2OWGYHGIGSD24OPDPXPDYDKDZNAVCNFSM6AAAAAA7BRKCPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJZG42TONJXGM). You are receiving this because you authored the thread.Message ID: @.***>

windymilla commented 12 months ago

Thanks Neil

The only thing I can see that I can possibly think is different in 1.6.0 to 1.5.3 is that the Tools menu has one extra entry in it, which makes it slightly longer of course. Is it almost filling your screen vertically and perhaps triggering some "clever" behaviour to try to fit it in, do you think?

A couple of things to test (not permanent fixes).

  1. You could try choosing a smaller font for the menus: Preferences->Appearance->Set Fonts..., then uncheck "Use System Default for Menu, Labels, Buttons, etc", which should unlock the "Menus, Labels, Buttons, etc." row of controls, and you should be able to click the arrows next to the font size to reduce it.
  2. An alternative would be to remove one or two entries from the menu by editing the source code, but I don't know (or don't recall) whether you would be comfortable doing that - don't do it if you're not confident - you could PM me and I could send you an edited file instead. If you are confident, then go to where you have 1.6.0 installed, then the lib subfolder, then the Guiguts subfolder of that, and edit MenuStructure.pm, and remove one or more entries removing from an open bracket to a close bracket with comma, e.g. Lines 512-518:
        [
            'command',
            '~Illustration Fixup...',
            -command => sub {
                ::errorcheckpop_up( $textwindow, $top, 'Illustration Fixup' );
            }
        ],

    Lines 502-508

        [
            'command',
            'Load Checkfile~...',
            -command => sub {
                ::errorcheckpop_up( $textwindow, $top, 'Load Checkfile' );
            }
        ],
noystergithub commented 12 months ago

Thank you Nigel, the first and simpler of your suggestions solves it. Reducing the font size for menus etc. (from 12 to 11) brings the bottom of the Tools menu clear of the bottom of the screen, and the menu no longer appears as a sticky movable box.

All the best Neil

On 08/11/2023 12:44 GMT Nigel @.***> wrote:

Thanks Neil The only thing I can see that I can possibly think is different in 1.6.0 to 1.5.3 is that the Tools menu has one extra entry in it, which makes it slightly longer of course. Is it almost filling your screen vertically and perhaps triggering some "clever" behaviour to try to fit it in, do you think? A couple of things to test (not permanent fixes).

  1. You could try choosing a smaller font for the menus: Preferences->Appearance->Set Fonts..., then uncheck "Use System Default for Menu, Labels, Buttons, etc", which should unlock the "Menus, Labels, Buttons, etc." row of controls, and you should be able to click the arrows next to the font size to reduce it.
  2. An alternative would be to remove one or two entries from the menu by editing the source code, but I don't know (or don't recall) whether you would be comfortable doing that - don't do it if you're not confident - you could PM me and I could send you an edited file instead. If you are confident, then go to where you have 1.6.0 installed, then the lib subfolder, then the Guiguts subfolder of that, and edit MenuStructure.pm, and remove one or more entries removing from an open bracket to a close bracket with comma, e.g. Lines 512-518: [ 'command', '~Illustration Fixup...', -command => sub { ::errorcheckpop_up( $textwindow, $top, 'Illustration Fixup' ); } ],

Lines 502-508 [ 'command', 'Load Checkfile~...', -command => sub { ::errorcheckpop_up( $textwindow, $top, 'Load Checkfile' ); } ],

— Reply to this email directly, view it on GitHub (https://github.com/DistributedProofreaders/guiguts/issues/1273#issuecomment-1801819390), or unsubscribe (https://github.com/notifications/unsubscribe-auth/A6K2OWHPFQSQUGO7VHQTV2LYDN5DTAVCNFSM6AAAAAA7BRKCPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBRHAYTSMZZGA). You are receiving this because you authored the thread.Message ID: @.***>

windymilla commented 11 months ago

Thanks Neil

Do you want me to look to see if I can make the menu shorter again, maybe by moving some entries into a sub-menu so you can go back to size 12 font? Or are you happy with having the size 11 font, in which case I'll close this issue.

noystergithub commented 11 months ago

Nigel

Thank you, I can manage fine with size 11. I may not be the only user affected, though. I tried pushing the font size up to 20 and the longer menus started behaving strangely - either not opening at all, or opening one of the sub-options at random. Reverting to size 11 all returned to normal.

Neil

On 08/11/2023 19:27 GMT Nigel @.***> wrote:

Thanks Neil Do you want me to look to see if I can make the menu shorter again, maybe by moving some entries into a sub-menu so you can go back to size 12 font? Or are you happy with having the size 11 font, in which case I'll close this issue. — Reply to this email directly, view it on GitHub (https://github.com/DistributedProofreaders/guiguts/issues/1273#issuecomment-1802514728), or unsubscribe (https://github.com/notifications/unsubscribe-auth/A6K2OWFUVG5KA3KAIGWUW2TYDPMI7AVCNFSM6AAAAAA7BRKCPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBSGUYTINZSHA). You are receiving this because you authored the thread.Message ID: @.***>

windymilla commented 11 months ago

Thanks, Neil - I'll close this for now, bear in mind the length of menus a bit more, and make that a higher priority if it appears to affect others.