search

DistributedProofreaders / ppwb

Post Processor's Workbench
GNU General Public License v3.0
5 stars 6 forks source link

Centralize tool logging #9

Closed cpeel closed 3 years ago

cpeel commented 3 years ago

For each tool run, log information about the run into a single file in $workdir. Also output each command used and the command output. This simplifies debugging and troubleshooting.

This MR also removes outputting the pptext version on the input page (it's on the run output already) and ensures that the upload stops if the AV scanner fails to run correctly.

Testable in the central-tool-logging sandbox.

asylumcs commented 3 years ago

Yes makes sense to me. Thank you.

srjfoo commented 3 years ago

General question/comment -- and this may be for a different MR -- for pptext, under "Select wordlist language(s), is the implication that pptext should not be run if a text is in a language not listed? One of my test projects is in Dutch, which is not listed. Even if spellcheck is not possible because of a missing dictionary, I would think that some of the other checks (excluding jeebies) would be useful. Could an "Other non-English" option be added that would disable spellcheck unless a good words file is provided?

cpeel commented 3 years ago

General question/comment -- and this may be for a different MR -- for pptext, under "Select wordlist language(s), is the implication that pptext should not be run if a text is in a language not listed? One of my test projects is in Dutch, which is not listed. Even if spellcheck is not possible because of a missing dictionary, I would think that some of the other checks (excluding jeebies) would be useful. Could an "Other non-English" option be added that would disable spellcheck unless a good words file is provided?

I'll defer that question to @asylumcs as I do not know the answer. We could make it such that the "you must pick a language" check only happens if the user does not check a language and selects spellcheck. IIRC pptext would be happy with that.

asylumcs commented 3 years ago

I think it's fine to run pptext if it's not a language on the list. Perhaps a user would not want to tick the "run spellcheck" box in some cases. And it's not really right to me to have a list anyway because there are perfectly good dictionaries loaded that do not have a checkbox. Wouldn't surprise me if Dutch were actually available. Back originally when pptext was in Python, I experimented with having the Natural Language Toolkit tell me the language so the user didn't have to chose from a list. I can't do that in Go.

cpeel commented 3 years ago

I create https://github.com/DistributedProofreaders/ppwb/issues/10 to address the pptext language selection issue that was raised.