search

DistributedScience / Distributed-Something

Run encapsulated docker containers that do... something in the Amazon Web Services infrastructure.
https://distributedscience.github.io/Distributed-Something
Other
7 stars 3 forks source link

Dashboards are always created #20

Closed bethac07 closed 1 year ago

bethac07 commented 1 year ago

CREATE_DASHBOARD and CLEAN_DASHBOARD have defaults set as 'False', which since that's a string, will cause if CREATE_DASHBOARD etc to always evaluate to True (since strings always evaluate to True). We should either change both defaults from 'False' to False OR do string value checking like if CREATE_DASHBOARD.lower()=='true'. Do you have a preference?

ErinWeisbart commented 1 year ago

Happy to fix to either way. Do you have a preference?

bethac07 commented 1 year ago

Dealer's choice