Closed ammen99 closed 4 years ago
Fixes #83
TODO:
[x] ServerCommandHandler, I'm waiting until more PRs get merged since right now I have to merge like 3 to get this.
[x] Figure out whether we'll have to listen for a specific signal in the main loop for gracefully exiting the server Moved to a separate issue
I also am not writing any unit tests for this, since I think that testing this is basically a system, not a unit test.
Looks good so far.
JohannesGaessler
commented
4 years ago JohannesGaessler
commented
4 years ago
Fixes #83
TODO:
[x] ServerCommandHandler, I'm waiting until more PRs get merged since right now I have to merge like 3 to get this.
[x]
Figure out whether we'll have to listen for a specific signal in the main loop for gracefully exiting the serverMoved to a separate issueI also am not writing any unit tests for this, since I think that testing this is basically a system, not a unit test.