search

DistributedTaskScheduling / JobAdder

Source code of the JobAdder project
GNU General Public License v3.0
2 stars 1 forks source link

tests: use paths relative to the test itself #117

Closed ammen99 closed 4 years ago

ammen99 commented 4 years ago

Relying on the current directory may break if we run tests from different directories.

I had a problem on my computer since I run the tests a little bit differently than the CI :) Also, I think we need to specify which docker version we need. For example, I had docker 1.13 or something like that, and it wasn't working. @JohannesGaessler Do you know which minimum version we need?

nikolatzotchev commented 4 years ago

I managed to run all test except the one that tests the mount point, I get no such file, for output_file.

nikolatzotchev commented 4 years ago

I have docker 18.09.8

ammen99 commented 4 years ago

I managed to run all test except the one that tests the mount point, I get no such file, for output_file.

Were the tests working without this PR?

JohannesGaessler commented 4 years ago

I don't know the minimum Docker version required. I have 19.03.6-ce installed locally and the tests were working.