DistributedTaskScheduling / JobAdder

Source code of the JobAdder project
GNU General Public License v3.0
2 stars 1 forks source link

Implementation of JobWorker, WorkerCommandHandler, server -> worker commands #128

Closed JohannesGaessler closed 4 years ago

JohannesGaessler commented 4 years ago

Fixes https://github.com/DistributedTaskScheduling/JobAdder/issues/65 . Fixes https://github.com/DistributedTaskScheduling/JobAdder/issues/66 .

As discussed in the meeting, I'm taking over the task of implementing the worker main class and the WorkerServerCommand classes. I changed the interface of the execute method of WorkerServerCommand classes to use DockerInterface instead of JobWorker. In addition to the things implemented in https://github.com/DistributedTaskScheduling/JobAdder/pull/112 I also implemented the following things that were missing:

JohannesGaessler commented 4 years ago

I also added admin_group to WorkerConfig.

nikolatzotchev commented 4 years ago

This looks good to me, only one question why do you keep the get_workload class, if we talked that we are not going to implement it.

JohannesGaessler commented 4 years ago

Because it's an optional feature that might get implemented someday if our project sees actual use.

JohannesGaessler commented 4 years ago

To be honest the unit tests are just something I forgot.

nikolatzotchev commented 4 years ago

I think this is good, let me know if you plan to add tests for the messages, otherwise I will approve. I'm not sure they are is such a need, because the important part (docker_interface) is already tested.

ammen99 commented 4 years ago

Seems like the Travis build also passes, I hope this issue is resolved soon.