search

DistributedTaskScheduling / JobAdder

Source code of the JobAdder project
GNU General Public License v3.0
2 stars 1 forks source link

Save ssh_config to the database. #150

Closed nikolatzotchev closed 4 years ago

nikolatzotchev commented 4 years ago

fixes #149 fixes #141 Somehow I forgot to add this. Fixed every test so that the work machines have ssh_config

ammen99 commented 4 years ago

This was forgotten in the PR which actuall added ssh config instead of work machine connection info, don't remember which one was that, but I know we added this after the database.

nikolatzotchev commented 4 years ago

Doest anyone have an idea how to fix this error.

nikolatzotchev commented 4 years ago

It looks like the tables are not being created in the integration test, no idea how it works in the mock, but doesn't in the real.

nikolatzotchev commented 4 years ago

wtf ok now the error is only local ¯_(ツ)_/¯ even the password is wrong for the database in this PR, and travis still passes what is going on.

nikolatzotchev commented 4 years ago

Ok I'm just retarded.

nikolatzotchev commented 4 years ago

should I try refactoring everything or should I leave it as so. I'm talking about WorkMachine default values.

JohannesGaessler commented 4 years ago

I think since we're short on time we should ultimately leave it as-is; the opportunity cost of changing things is too high.