search

DistributedTaskScheduling / JobAdder

Source code of the JobAdder project
GNU General Public License v3.0
2 stars 1 forks source link

Scheduler test #173

Closed ammen99 closed 4 years ago

ammen99 commented 4 years ago

This contains a lot of fixes I found when testing.

I put the file in ja_integration because my autocomplete does not work in test/, I just realized that even though I had this problem ever since the beginning.

Once the PR is approved, I can move the file to where the other tests are if this is a big problem.

EDIT: forgot to open this as draft, I will be adding a few more tests but I hope I don't need to fix as many issues as I had to up to now :)

Fixes #161

JohannesGaessler commented 4 years ago

Once the PR is approved, I can move the file to where the other tests are if this is a big problem.

Please do, just to keep things organized. Also, you didn't adjust .travis.yml to include the tests in ja_integration, did you?

JohannesGaessler commented 4 years ago

A rebase onto master would be convenient for reviewing. Also, please notify us when this PR has all the tests you plan to implement.

ammen99 commented 4 years ago

I think it should be ready for review now.

I intend to implement cancelling jobs in a separate PR because it will require changes to the database, scheduler and of course a new test.

ammen99 commented 4 years ago

Btw I moved the two simple test cases from base.py to test_simple.py because I don't think we want to run them multiple times for each test case.

nikolatzotchev commented 4 years ago

2020-03-29-144014_grim why do I get this one when running the tests.

JohannesGaessler commented 4 years ago

why do I get this one when running the tests.

Probably because our packages are not on your PATH / PYTHONPATH. You could fix this by doing either of the following:

ammen99 commented 4 years ago

@JohannesGaessler It was my fault, I had forgotten to git add the remotes.