DistributedTaskScheduling / JobAdder

Source code of the JobAdder project
GNU General Public License v3.0
2 stars 1 forks source link

Installation guide, misc adjustments #176

Closed JohannesGaessler closed 4 years ago

JohannesGaessler commented 4 years ago

Fixes https://github.com/DistributedTaskScheduling/JobAdder/issues/166 .

This PR adds an installation guide. It also does a few related changes:

JohannesGaessler commented 4 years ago

lgtm, I think it would also bw nice to say we want md5/password auth.

Authentication for what?

ammen99 commented 4 years ago

lgtm, I think it would also bw nice to say we want md5/password auth.

Authentication for what?

Password authentication for the database. I can imagine a person not familiar with this file will have difficulties, just as I had, so that's why I think we should say that the admin needs to enable md5 authentication method.

JohannesGaessler commented 4 years ago

Just to make sure there isn't a misunderstanding: I added a line below the link to authentication methods that mentions that JobAdder was designed with password authentication in mind. Is this not sufficient?

ammen99 commented 4 years ago

I had missed the second line, sorry.

ammen99 commented 4 years ago

If you squash your commits, it is ready for merge.

ammen99 commented 4 years ago

@JohannesGaessler By the way, you can also merge pull requests :)