search

DistributedTaskScheduling / JobAdder

Source code of the JobAdder project
GNU General Public License v3.0
2 stars 1 forks source link

Loosened integration test timings to account for low-power CPUs #193

Closed JohannesGaessler closed 4 years ago

JohannesGaessler commented 4 years ago

I installed JobAdder on a 1.2 GHz ARM SBC and found that several integration tests were failing. This was due to the current timings being too tight for very slow systems. This PR loosens those timings so that the integration tests succeed on slow system. The looser timings extend the time required to complete the tests by 27 seconds.

JohannesGaessler commented 4 years ago

I disagree. I think that ensuring the tests work correctly on all (or at least most) platforms is much more important than saving a few seconds in testing.

ammen99 commented 4 years ago

I disagree. I think that ensuring the tests work correctly on all (or at least most) platforms is much more important than saving a few seconds in testing.

I agree with your argument when it comes to platforms which are our target hardware, but your NanoPi is not one of those :)

Plus, tests are for developers, so it should work on our machines. Faster tests also let you develop code & fix bugs faster. This does not apply anymore, since we are done with both implementation and QA.