search

DistributedTaskScheduling / JobAdder

Source code of the JobAdder project
GNU General Public License v3.0
2 stars 1 forks source link

Fixed effective user being root for admin users #201

Closed JohannesGaessler closed 4 years ago

JohannesGaessler commented 4 years ago

Fixes https://github.com/DistributedTaskScheduling/JobAdder/issues/168 .

On master the effective user for users in the jobadder group is set to 0, i.e. root. This is not just a cosmetic issue. Jobs submitted by users in the jobadder group were run as root, effectively granting root access to all users in the jobadder group. This PR revises how a user being admin is checked to prevent this.

JohannesGaessler commented 4 years ago

I think we should just disallow submitting jobs for other users (or maybe allow only root to do so?). I think it is not a very useful feature anyways and security is more important.