search

DistrictDataLabs / baleen

An automated ingestion service for blogs to construct a corpus for NLP research.
MIT License
86 stars 38 forks source link

Corrected README code snippet #92

Closed dmahendrakar closed 7 years ago

dmahendrakar commented 7 years ago

Corrected the README.md code snippet tag. Thanks for the great work!

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 886442e674f190b541981f37e9851487b801dc34 on dmahendrakar:master into on DistrictDataLabs:master.

bbengfort commented 7 years ago

@dmahendrakar thank you so much for helping us correct the README, we appreciate you taking the time to check Baleen out and use it. If you're using it for anything interesting, we'd love to hear it!

The trick here was that we had actually already fixed the readme in the develop branch, as well as added some new features and Python 3.5 compatibility -- we usually merge releases into the master branch when the code is stable. Unfortunately this means that your changes have already been made, but it was important to highlight the fact that we should do a new release soon.

@janetriley @will2041 do you think we're ready for a new release? My feeling is that we are.

janetriley commented 7 years ago

@bbengfort seems like it's in good shape, and there are a lot of improvements to share. I'd say yes.

bbengfort commented 7 years ago

@janetriley ok - I'll wait for you to merge the sanitize command line flag, then I'll do the release. Let me know when it's ready.