Closed lauralorenz closed 7 years ago
@bahadasx if you want to take a look at this and see if the dev instructions work for you, I think this would be good to merge before we get anyone else into the codebase. I put testing instructions and an overview, but can go over it with you/anyone tomorrow(/today....) also cc @ojedatony1616 @bbengfort
This PR updates the docker-based and vagrant-based development scripts, configuration, and READMEs to reflect the current state of cultivar on develop. This PR falls just short of making the Vagrant set up full-service since it doesn't set up the messaging backend, but at least now it has a site.
How to test
You might want to start TOTALLY from scratch (re: Vagrant install, Docker install) but if not that far back, at least get rid of your old vagrant box and docker images just to be safe.
Follow the README sections from this PR on the dev environment with
You can also smoke test the messaging backend for the docker configuration by triggering a background tasks via uploading a data set and follow logs for celery (and rabbitmq if you like) to make sure that background tasks are being executed by workers to prove out the messaging backend
NOTE: I considered setting up an emailing backend for dev not worth fixing from a docker perspective (and it's already non existent from the Vagrant perspective) since for dev purposes we have no email configuration necessary at this point (no email logging and we don't appear to use it elsewhere in the project).
Implementation notes/notable things
To fix the Vagrant setup:
python
executable for the base vagrant box we're using (ubuntu/trusty32
) points to python 2.7. So I switched the default by having the virtualenvironment the Vagrantfile provisions use the python3 executable (which is really python 3.4.1 in this ubuntu version, but we can deal with upgrades later if we want).To fix the Docker setup:
Overall fixes:
.env
files were thinking pythony (ENV_VAR=None
) instead of bashy (ENV_VAR=1
) which is not ze sameOut of scope
docker-compose.yml
)