Closed busFred closed 3 years ago
@busFred thank you for contributing to Yellowbrick! I'm running some other tests right now, but will review shortly.
Merging #1186 (ce177c5) into develop (07ef358) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## develop #1186 +/- ##
========================================
Coverage 90.44% 90.44%
========================================
Files 90 90
Lines 5076 5076
========================================
Hits 4591 4591
Misses 485 485
Impacted Files | Coverage Δ | |
---|---|---|
yellowbrick/cluster/elbow.py | 98.49% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 07ef358...ce177c5. Read the comment docs.
This PR fixes #1185 which ValueError is thrown when not all cluster center has at least one input data point assigned to it.
I have made the following changes:
labels = le.fit_transform(labels)
, modification were made to just callle.fit(labels)
without reassigning input argumentlabels
.Sample Code and Plot
Console Output
TODOs and questions
Still to do: None
Questions for the @DistrictDataLabs/team-oz-maintainers:
CHECKLIST
pytest
?make html
?