Closed bbengfort closed 2 years ago
Merging #1189 (497c15f) into develop (df45161) will increase coverage by
0.03%
. The diff coverage is96.55%
.
@@ Coverage Diff @@
## develop #1189 +/- ##
===========================================
+ Coverage 90.42% 90.46% +0.03%
===========================================
Files 90 91 +1
Lines 5097 5126 +29
===========================================
+ Hits 4609 4637 +28
- Misses 488 489 +1
Impacted Files | Coverage Δ | |
---|---|---|
yellowbrick/contrib/prepredict.py | 96.55% <96.55%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update df45161...497c15f. Read the comment docs.
Tests passed *whew!
@lwgray thanks for the review! It's been so long since I did this that I don't really remember all the details, but I'll try to answer:
contrib
module is supposed to be for third party or not fully fledged out code; it's kind of an auxiliary so it doesn't necessarily follow the same rules that the other YB visualizers do. score
method was really just to get visualizers to work with this data; I could see the scoring method being a useful argument; I recommend that we open up a story to add that feature in the future.
A contrib estimator to wrap inferences made outside of the Yellowbrick workflow. This estimator can wrap predicted data for use in many visualizers (though not all, depending on if the visualizer needs access to learned attributes) or load data from disk or via a callable.
I have made the following changes:
PrePredict
a contrib estimatorPrePredict
estimatorPrePredict
estimatorSample Code and Plot
Please see the documentation for sample code.
Questions for the @DistrictDataLabs/team-oz-maintainers:
CHECKLIST
pytest
?make html
?