DistrictDataLabs / yellowbrick

Visual analysis and diagnostic tools to facilitate machine learning model selection.
http://www.scikit-yb.org/
Apache License 2.0
4.3k stars 559 forks source link

[WIP] Updates to YB for sklearn v1 #1197

Closed rebeccabilbro closed 2 years ago

rebeccabilbro commented 3 years ago

This PR updates a few baseline images and makes some other small edits to get yellowbrick working with scikit-learn v1.

I have made the following changes:

  1. updated baseline images (not really sure why some failed and not others, but the tol failures were huge, like >30 rmse, so I just updated them)
  2. updated calls to Bernoulli, make_blobs, and load_iris
  3. removed try/except pattern from some older tests
  4. updated test requirements.txt

TODOs and questions

Still to do:

CHECKLIST

codecov[bot] commented 3 years ago

Codecov Report

Merging #1197 (33149a8) into develop (2eb8e3e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 33149a8 differs from pull request most recent head fe91135. Consider uploading reports for the commit fe91135 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1197   +/-   ##
========================================
  Coverage    90.43%   90.43%           
========================================
  Files           90       90           
  Lines         5089     5089           
========================================
  Hits          4602     4602           
  Misses         487      487           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2eb8e3e...fe91135. Read the comment docs.