search

DistrictDataLabs / yellowbrick

Visual analysis and diagnostic tools to facilitate machine learning model selection.
http://www.scikit-yb.org/
Apache License 2.0
4.3k stars 559 forks source link

2022 Maintenance #1207

Closed bbengfort closed 2 years ago

bbengfort commented 2 years ago

This PR performs a couple of minor maintenance items:

  1. Switches to a YB-specific data lake for datasets storage
  2. Updates nltk dependency that has a CVE

Other minor updates may follow; this PR will require a new release.

bbengfort commented 2 years ago

😅 - the YB signatures in the manifests saved me from making a mistake! The tests kept failing because of signature verification errors; luckily I realized that I accidentally linked to the pre-v1.0 datasets instead of the v1.0 datasets before I made a mistake like changing the signatures! That said, if the tests pass, I'm confident that this PR is ready to go.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1207 (eb56022) into develop (8611c62) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1207   +/-   ##
========================================
  Coverage    90.43%   90.43%           
========================================
  Files           90       90           
  Lines         5089     5089           
========================================
  Hits          4602     4602           
  Misses         487      487

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8611c62...eb56022. Read the comment docs.