DistrictDataLabs / yellowbrick

Visual analysis and diagnostic tools to facilitate machine learning model selection.
http://www.scikit-yb.org/
Apache License 2.0
4.3k stars 559 forks source link

Create tests for `is_fitted` parameter for ResidualsPlot and PredictionError #1223

Closed lwgray closed 2 years ago

lwgray commented 2 years ago

This PR adds tests to #1221. These tests assure us that the is_fitted param's state is maintained when the visualizer is instantiated.

I have made the following changes:

  1. Added test for ResidualPlots
  2. Added test for PredictionError
  3. Removed unnecessary import so that flake8 passed
codecov[bot] commented 2 years ago

Codecov Report

Merging #1223 (8828449) into develop (4be320d) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1223   +/-   ##
========================================
  Coverage    90.45%   90.45%           
========================================
  Files           91       91           
  Lines         5135     5135           
========================================
  Hits          4645     4645           
  Misses         490      490           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4be320d...8828449. Read the comment docs.