search

DistrictDataLabs / yellowbrick

Visual analysis and diagnostic tools to facilitate machine learning model selection.
http://www.scikit-yb.org/
Apache License 2.0
4.3k stars 559 forks source link

Add Dropping Curve Documentation #1235

Closed lwgray closed 2 years ago

lwgray commented 2 years ago

Now that we've merged in our new Dropping Curve with https://github.com/DistrictDataLabs/yellowbrick/pull/1206, which does not include any documentation, we'd like to follow up by adding docs with a description of the use cases.

@charlesincharge has already added comments and an article in his original issue https://github.com/DistrictDataLabs/yellowbrick/issues/1204

@DistrictDataLabs/team-oz-maintainers

wagner2010 commented 2 years ago

I'm working on the conda release and a few other promised deliverables but I'm happy to take this on next if someone else will join me!

charlesbmi commented 2 years ago

@wagner2010 I can turn my original feature request into some docs but would definitely benefit from your help looking over it!

wagner2010 commented 2 years ago

That'd be amazing. Go for making a pr! https://www.scikit-yb.org/en/latest/contributing/developing_visualizers.html#documentation Thanks @charlesincharge

charlesbmi commented 2 years ago

@wagner2010 I added a pull request: https://github.com/DistrictDataLabs/yellowbrick/pull/1241 . Can you let me know what you think when you have a moment? Thanks!

wagner2010 commented 2 years ago

I will; awesome job @charlesincharge ! Thanks

bbengfort commented 2 years ago

Closed by #1241