DistrictDataLabs / yellowbrick

Visual analysis and diagnostic tools to facilitate machine learning model selection.
http://www.scikit-yb.org/
Apache License 2.0
4.3k stars 559 forks source link

Build sklearn pipeline tests for visualizers #1259

Closed pdamodaran closed 2 years ago

pdamodaran commented 2 years ago

This PR fixes #1257 (If you are fixing a bug) which reported a bug that caused a problem to occur when users...

(or if you are introducing a new feature) which requested a feature to allow the user to...

I have made the following changes:

  1. Added pipeline tests for the following:
    • DiscriminationThreshold
    • LearningCurve
    • FeatureImportances
    • ResidualsPlot
    • AlphaSelection

Sample Code and Plot

If you are adding or modifying a visualizer, PLEASE include a sample plot here along with the code you used to generate it.

TODOs and questions

Still to do:

CHECKLIST

codecov[bot] commented 2 years ago

Codecov Report

Merging #1259 (2eb88c9) into develop (cc7a415) will increase coverage by 0.07%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1259      +/-   ##
===========================================
+ Coverage    90.81%   90.88%   +0.07%     
===========================================
  Files           93       93              
  Lines         5301     5301              
===========================================
+ Hits          4814     4818       +4     
+ Misses         487      483       -4     
Impacted Files Coverage Δ
yellowbrick/classifier/threshold.py 99.35% <0.00%> (+0.64%) :arrow_up:
yellowbrick/regressor/residuals.py 90.56% <0.00%> (+0.94%) :arrow_up:
yellowbrick/regressor/alphas.py 95.60% <0.00%> (+1.09%) :arrow_up:
yellowbrick/model_selection/learning_curve.py 100.00% <0.00%> (+1.88%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

pdamodaran commented 2 years ago

Thanks @lwgray!