DistrictDataLabs / yellowbrick

Visual analysis and diagnostic tools to facilitate machine learning model selection.
http://www.scikit-yb.org/
Apache License 2.0
4.3k stars 559 forks source link

Build sklearn pipeline tests for visualizers - Part 2 #1262

Closed pdamodaran closed 2 years ago

pdamodaran commented 2 years ago

This PR fixes #1256 (If you are fixing a bug) which reported a bug that caused a problem to occur when users...

(or if you are introducing a new feature) which requested a feature to allow the user to...

I have made the following changes:

  1. Added pipeline tests for Prediction Error
  2. Added pipeline tests for InterClusterDistanceMetric

TODOs and questions

Still to do:

Questions for the @DistrictDataLabs/team-oz-maintainers:

CHECKLIST

codecov[bot] commented 2 years ago

Codecov Report

Merging #1262 (a86ddaf) into develop (f60f847) will increase coverage by 0.05%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1262      +/-   ##
===========================================
+ Coverage    90.75%   90.81%   +0.05%     
===========================================
  Files           93       93              
  Lines         5301     5301              
===========================================
+ Hits          4811     4814       +3     
+ Misses         490      487       -3     
Impacted Files Coverage Δ
yellowbrick/cluster/icdm.py 95.27% <0.00%> (+0.78%) :arrow_up:
yellowbrick/regressor/prediction_error.py 96.72% <0.00%> (+3.27%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

pdamodaran commented 2 years ago

Thanks for catching that @lwgray! I have added it to the TODO list. The visualizer will likely need to be modified for it to work.