search

DistrictDataLabs / yellowbrick

Visual analysis and diagnostic tools to facilitate machine learning model selection.
http://www.scikit-yb.org/
Apache License 2.0
4.3k stars 559 forks source link

Contributors icon added #1274

Closed ekramasif closed 2 years ago

ekramasif commented 2 years ago
Contributors icon added on Readme.md This PR fixes #issue_number _(If you are fixing a bug)_ which reported a bug that caused a problem to occur when users... _(or if you are introducing a new feature)_ which requested a feature to allow the user to... I have made the following changes: 1. Contributors icon added on Readme.md
bbengfort commented 2 years ago

@ekramasif thank you for your interest in Yellowbrick and for opening a PR as an initial contribution! We really appreciate that you're thinking of us. I think that it's a nice thought to add a contributors image to our README, however it seems to interrupt the flow of documentation (e.g. preventing readers from getting to the section about datasets) and is a bit redundant with our contributor's images on GitHub already. If you'd like to make a case for inclusion of this into our README, I'm happy to listen or if any of the @DistrictDataLabs/team-oz-maintainers has an opinion on this, please feel free to chime in. However, for now I'm going to go ahead and close this PR.