search

DistrictDataLabs / yellowbrick

Visual analysis and diagnostic tools to facilitate machine learning model selection.
http://www.scikit-yb.org/
Apache License 2.0
4.29k stars 559 forks source link

[SilhouetteVisualizer] Constructor argument is_fitted is ignored during initialization #1290

Closed stergion closed 1 year ago

stergion commented 1 year ago

Describe the bug Constructor argument is_fitted is ignored during initialization.

To Reproduce

https://github.com/DistrictDataLabs/yellowbrick/blob/40e0482a6eede02ebbc9ccffcb58cff1953a4ce1/yellowbrick/cluster/silhouette.py#L115-L127

Expected behavior

        # Initialize the visualizer bases
        super(SilhouetteVisualizer, self).__init__(estimator, ax=ax, is_fitted=is_fitted, **kwargs)
bbengfort commented 1 year ago

Thank you so much for opening a PR for this @stergion! Just waiting for the tests to pass and we can merge and close this issue.