Closed NikoT98 closed 1 year ago
Grand merci @NikoT98! This is an incredibly generous contribution to Yellowbrick, and I am so excited to make your translation available to the Yellowbrick community.
One question -- Would you be open to me moving your translation into a new repository created (5 minutes ago 😅 ) specifically for the French documentation? We did something similar with Spanish last year, which allowed us to create this new Spanish language version in ReadTheDocs.
Based on your preference, I can either open a new PR into that repo with your commits and credit you with the translation, or you could open the PR directly into that repo.
Please let me know your preference, and again, merci mille fois for your thoughtful translation and your excellent PR!
Thank you for your email.
It's with great pleasure that I am contributing to Yellowbrick !
That would be awesome if you could open the PR into the French repository :)
Best regards. Nicola
On Tue, Jun 27, 2023 at 7:18 PM Rebecca Bilbro @.***> wrote:
Grand merci @NikoT98 https://github.com/NikoT98! This is an incredibly generous contribution to Yellowbrick, and I am so excited to make your translation available to the Yellowbrick community.
One question -- Would you be open to me moving your translation into a new repository https://github.com/DistrictDataLabs/yellowbrick-docs-fr created (5 minutes ago 😅 ) specifically for the French documentation? We did something similar with Spanish https://github.com/DistrictDataLabs/yellowbrick-docs-es last year, which allowed us to create this new Spanish language version in ReadTheDocs https://www.scikit-yb.org/es/latest/.
Based on your preference, I can either open a new PR into that repo with your commits and credit you with the translation, or you could open the PR directly into that repo.
Please let me know your preference, and again, merci mille fois for your thoughtful translation and your excellent PR!
— Reply to this email directly, view it on GitHub https://github.com/DistrictDataLabs/yellowbrick/pull/1305#issuecomment-1609842454, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWZAYL33VUJTCGAK543HTYTXNMBV7ANCNFSM6AAAAAAZUY7WWU . You are receiving this because you were mentioned.Message ID: @.***>
Hi Nicola,
Excellent, thank you so much; I'll get to that as soon as possible!
Best Regards, Benjamin Bengfort mens divinior
On Sat, Jul 1, 2023 at 12:04 PM Nicola Tabbah @.***> wrote:
Thank you for your email.
It's with great pleasure that I am contributing to Yellowbrick !
That would be awesome if you could open the PR into the French repository :)
Best regards. Nicola
On Tue, Jun 27, 2023 at 7:18 PM Rebecca Bilbro @.***> wrote:
Grand merci @NikoT98 https://github.com/NikoT98! This is an incredibly generous contribution to Yellowbrick, and I am so excited to make your translation available to the Yellowbrick community.
One question -- Would you be open to me moving your translation into a new repository https://github.com/DistrictDataLabs/yellowbrick-docs-fr
created (5 minutes ago 😅 ) specifically for the French documentation? We did something similar with Spanish https://github.com/DistrictDataLabs/yellowbrick-docs-es last year, which allowed us to create this new Spanish language version in ReadTheDocs https://www.scikit-yb.org/es/latest/.
Based on your preference, I can either open a new PR into that repo with your commits and credit you with the translation, or you could open the PR directly into that repo.
Please let me know your preference, and again, merci mille fois for your thoughtful translation and your excellent PR!
— Reply to this email directly, view it on GitHub < https://github.com/DistrictDataLabs/yellowbrick/pull/1305#issuecomment-1609842454>,
or unsubscribe < https://github.com/notifications/unsubscribe-auth/AWZAYL33VUJTCGAK543HTYTXNMBV7ANCNFSM6AAAAAAZUY7WWU>
. You are receiving this because you were mentioned.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/DistrictDataLabs/yellowbrick/pull/1305#issuecomment-1615999547, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFWD3XCJ5BQ3PODQVXDSKLXOBKAZANCNFSM6AAAAAAZUY7WWU . You are receiving this because you are subscribed to this thread.Message ID: @.***>
...et voilà @NikoT98 !! 🎉
Here's the repo and the brand-new deployed docs en français on ReadTheDocs.
J'espère qu'ils vous vont bien 🤩 Je fermerai celui ci et si vous avez des ajouts, vous pouvez les ajouter au nouveau repo, d'acc ? Je vous remercie 🙏 encore pour votre contribution 🙌 extrêmement généreuse!
… the docs
This PR fixes #issuenumber (If you are fixing a bug)_ which reported a bug that caused a problem to occur when users...
(or if you are introducing a new feature) which requested a feature to allow the user to...
I have made the following changes:
1. 2. 3.
Sample Code and Plot
If you are adding or modifying a visualizer, PLEASE include a sample plot here along with the code you used to generate it.
TODOs and questions
Still to do:
Questions for the @DistrictDataLabs/team-oz-maintainers:
CHECKLIST
pytest
?make html
(must be run fromdocs/
)?