Open bbengfort opened 7 years ago
@NealHumphrey, @balavenkatesan, @ndanielsen -- I could use a second pair of eyes on this if any of you guys had some time to take a look. Checkout my alphas notebook in examples, and the yellowbrick/regressor/alphas.py package.
The
AlphaSelection
visualizer, implemented in #103 has a slight bug:Right now the alphas and errors selection method uses a search to find the right attributes on the model (rather than responding to specific model names). However, some models return different values for the attributes in different scenarios, resulting in an error regarding the mismatch between x and y values during plotting (must have same shape).
For example, RidgeCV
cv_values_
can be:But the current implementation only handles the shape [n_samples, n_alphas].
Additionally ElasticNetCV
mse_path_
can be:Which means we're probably not doing the right average on this array.
Basically, we need to do a better job of figuring out what the alphas and mse error properties are, computing the scores for visualization; I think right now the plots might just be wrong.